From: Russ Cox Date: Thu, 17 Apr 2014 20:25:38 +0000 (-0400) Subject: cmd/pack: avoid ./ import in test (fix Windows build) X-Git-Tag: go1.3beta1~25 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=576318c7bd9c1deeb5877df65dc26aeb53999ee2;p=gostls13.git cmd/pack: avoid ./ import in test (fix Windows build) It is possible to use ./ imports on Windows but it requires some extra command-line work ('go build' does this automatically, but we can't use 'go build' here). Instead, use an ordinary import and -I/-L, which are easier to use. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/89040043 --- diff --git a/src/cmd/pack/pack_test.go b/src/cmd/pack/pack_test.go index bd4b224aff..b2be74b097 100644 --- a/src/cmd/pack/pack_test.go +++ b/src/cmd/pack/pack_test.go @@ -247,7 +247,7 @@ func TestLargeDefs(t *testing.T) { main := filepath.Join(dir, "main.go") prog := ` package main - import "./large" + import "large" var V large.T func main() { println("ok") @@ -267,8 +267,8 @@ func TestLargeDefs(t *testing.T) { run("go", "build", "cmd/pack") // writes pack binary to dir run("go", "tool", char+"g", "large.go") run("./pack", "grc", "large.a", "large."+char) - run("go", "tool", char+"g", "main.go") - run("go", "tool", char+"l", "-o", "a.out", "main."+char) + run("go", "tool", char+"g", "-I", ".", "main.go") + run("go", "tool", char+"l", "-L", ".", "-o", "a.out", "main."+char) out := run("./a.out") if out != "ok\n" { t.Fatal("incorrect output: %q, want %q", out, "ok\n")