From: David Symonds Date: Mon, 14 May 2012 00:05:39 +0000 (+1000) Subject: misc/dashboard/codereview: set In-Reply-To header to properly thread mail. X-Git-Tag: go1.1rc2~3218 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=58bcec62c0f375f10e3bb32efc402e9c245c734b;p=gostls13.git misc/dashboard/codereview: set In-Reply-To header to properly thread mail. R=adg CC=golang-dev https://golang.org/cl/6208051 --- diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go index e92b4e1a46..0b7eccc733 100644 --- a/misc/dashboard/codereview/dashboard/cl.go +++ b/misc/dashboard/codereview/dashboard/cl.go @@ -12,6 +12,7 @@ import ( "html/template" "io" "net/http" + netmail "net/mail" "net/url" "regexp" "sort" @@ -192,8 +193,11 @@ func handleAssign(w http.ResponseWriter, r *http.Request) { Subject: cl.Subject + " (issue " + n + ")", Body: "R=" + rev + "\n\n(sent by gocodereview)", } - // TODO(dsymonds): Use cl.LastMessageID as the In-Reply-To header - // when the appengine/mail package supports that. + if cl.LastMessageID != "" { + msg.Headers = netmail.Header{ + "In-Reply-To": []string{cl.LastMessageID}, + } + } if err := mail.Send(c, msg); err != nil { c.Errorf("mail.Send: %v", err) }