From: Bryan C. Mills <bcmills@google.com>
Date: Fri, 1 Apr 2022 19:55:56 +0000 (-0400)
Subject: cmd/go/internal/work: omit modinfo line from cache key when empty
X-Git-Tag: go1.19beta1~760
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=592078ff3f7d938b2fbcd98ddcb72e0d2748fdb1;p=gostls13.git

cmd/go/internal/work: omit modinfo line from cache key when empty

Cache keys are dumped in case of mismatch; an empty modinfo string
adds noise to that dump without a corresponding benefit.

For #52009.

Change-Id: I1b4cd85fa5ff920973552fc94977954f93622a32
Reviewed-on: https://go-review.googlesource.com/c/go/+/398059
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
---

diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go
index 4252209f10..0c8e1dcdaf 100644
--- a/src/cmd/go/internal/work/exec.go
+++ b/src/cmd/go/internal/work/exec.go
@@ -303,7 +303,9 @@ func (b *Builder) buildActionID(a *Action) cache.ActionID {
 			fmt.Fprintf(h, "fuzz %q\n", fuzzFlags)
 		}
 	}
-	fmt.Fprintf(h, "modinfo %q\n", p.Internal.BuildInfo)
+	if p.Internal.BuildInfo != "" {
+		fmt.Fprintf(h, "modinfo %q\n", p.Internal.BuildInfo)
+	}
 
 	// Configuration specific to compiler toolchain.
 	switch cfg.BuildToolchainName {