From: Ian Lance Taylor <iant@golang.org>
Date: Mon, 7 Jan 2019 21:35:53 +0000 (-0800)
Subject: cmd/go: improve error message for names forbidden by Windows
X-Git-Tag: go1.12beta2~22
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5a0743b020d3bf7875edd5ed50c9ee69d728e10e;p=gostls13.git

cmd/go: improve error message for names forbidden by Windows

Fixes #29589

Change-Id: I69ad461e70b236d9729a42053e35128437449e32
Reviewed-on: https://go-review.googlesource.com/c/156658
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/go/internal/module/module.go b/src/cmd/go/internal/module/module.go
index 8afd2739b8..481a90b1c4 100644
--- a/src/cmd/go/internal/module/module.go
+++ b/src/cmd/go/internal/module/module.go
@@ -226,7 +226,7 @@ func checkElem(elem string, fileName bool) error {
 	}
 	for _, bad := range badWindowsNames {
 		if strings.EqualFold(bad, short) {
-			return fmt.Errorf("disallowed path element %q", elem)
+			return fmt.Errorf("%q disallowed as path element component on Windows", short)
 		}
 	}
 	return nil