From: Constantin Konstantinidis <constantinkonstantinidis@gmail.com>
Date: Sat, 28 Jul 2018 08:16:40 +0000 (+0200)
Subject: cmd/go: uses SID of group Guests to test ACL
X-Git-Tag: go1.11beta3~65
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5ad0a524d23b9b69c8c3caddbdf2dfe235c4d725;p=gostls13.git

cmd/go: uses SID of group Guests to test ACL

The test TestACL failed when ran on a Windows set
up in another language as the "Guest" account
name is translated. The SID of the group of Guests
always exist and is used instead.

Fixes #26658

Change-Id: Ia885d08a9e50563787e389c2d2dc2547881a2943
Reviewed-on: https://go-review.googlesource.com/126598
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/go/go_windows_test.go b/src/cmd/go/go_windows_test.go
index f278741c8b..99af3d43dc 100644
--- a/src/cmd/go/go_windows_test.go
+++ b/src/cmd/go/go_windows_test.go
@@ -97,7 +97,7 @@ func TestACL(t *testing.T) {
 	// will make all files created in TestACL/tmp have different
 	// security attributes to the files created in TestACL.
 	runIcacls(t, newtmpdir,
-		"/grant", "guest:(oi)(ci)f", // add Guest user to have full access
+		"/grant", "*S-1-5-32-546:(oi)(ci)f", // add Guests group to have full access
 	)
 
 	src := filepath.Join(tmpdir, "main.go")