From: Dave Cheney Date: Sat, 1 Mar 2014 21:30:45 +0000 (+1100) Subject: sync/atomic: skip broken tests on freebsd/arm and netbsd/arm X-Git-Tag: go1.3beta1~523 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5b456c74889e0316feda328bf3be1ed11f549519;p=gostls13.git sync/atomic: skip broken tests on freebsd/arm and netbsd/arm Update #7338 The nil deref tests are currently failing on the *bsd/arm platforms. In an effort to avoid the build deteriorating further I would like to skip these tests on freebsd/arm and netbsd/arm. LGTM=bradfitz, minux.ma R=golang-codereviews, bradfitz, minux.ma CC=golang-codereviews https://golang.org/cl/69870045 --- diff --git a/src/pkg/sync/atomic/atomic_test.go b/src/pkg/sync/atomic/atomic_test.go index c702158e8c..a5f44f70d5 100644 --- a/src/pkg/sync/atomic/atomic_test.go +++ b/src/pkg/sync/atomic/atomic_test.go @@ -1463,6 +1463,9 @@ func TestUnaligned64(t *testing.T) { } func TestNilDeref(t *testing.T) { + if p := runtime.GOOS + "/" + runtime.GOARCH; p == "freebsd/arm" || p == "netbsd/arm" { + t.Skipf("issue 7338: skipping test on %q", p) + } funcs := [...]func(){ func() { CompareAndSwapInt32(nil, 0, 0) }, func() { CompareAndSwapInt64(nil, 0, 0) },