From: Michael Pratt Date: Fri, 30 Jun 2023 18:32:39 +0000 (-0400) Subject: runtime: check GOFLAGS not GCFLAGS X-Git-Tag: go1.21rc3~2^2~35 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5b72f45dd1;p=gostls13.git runtime: check GOFLAGS not GCFLAGS GCFLAGS doesn't have any defined meaning. cmd/dist enables mayMoreStackPreempt with GOFLAGS. For #55160. Change-Id: I7ac71e4a1a983a56bd228ab5d24294db5cc595f7 Reviewed-on: https://go-review.googlesource.com/c/go/+/507359 Run-TryBot: Michael Pratt TryBot-Result: Gopher Robot Reviewed-by: Michael Knyszek Auto-Submit: Michael Pratt --- diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go index 07060b8fab..6bca2ac66e 100644 --- a/src/runtime/crash_unix_test.go +++ b/src/runtime/crash_unix_test.go @@ -76,7 +76,7 @@ func TestCrashDumpsAllThreads(t *testing.T) { testenv.MustHaveGoBuild(t) - if strings.Contains(os.Getenv("GCFLAGS"), "mayMoreStackPreempt") { + if strings.Contains(os.Getenv("GOFLAGS"), "mayMoreStackPreempt") { // This test occasionally times out in this debug mode. This is probably // revealing a real bug in the scheduler, but since it seems to only // affect this test and this is itself a test of a debug mode, it's not