From: Cherry Mui Date: Wed, 22 Sep 2021 17:23:47 +0000 (-0400) Subject: cmd/compile: update comments with ABI aliases/wrappers X-Git-Tag: go1.18beta1~1234 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5b75a9b2c3078ab2ef8398c47be5b30ea02c03d3;p=gostls13.git cmd/compile: update comments with ABI aliases/wrappers ABI aliases are gone. Change-Id: I0f5676d8730cac14b7495dd6c0c1e08ca85a1c77 Reviewed-on: https://go-review.googlesource.com/c/go/+/351531 Trust: Cherry Mui Reviewed-by: Than McIntosh --- diff --git a/src/cmd/compile/internal/ssagen/abi.go b/src/cmd/compile/internal/ssagen/abi.go index eabd232791..3a653e46b4 100644 --- a/src/cmd/compile/internal/ssagen/abi.go +++ b/src/cmd/compile/internal/ssagen/abi.go @@ -218,8 +218,6 @@ func (s *SymABIs) GenABIWrappers() { } if !buildcfg.Experiment.RegabiWrappers { - // We'll generate ABI aliases instead of - // wrappers once we have LSyms in InitLSym. continue } @@ -251,10 +249,9 @@ func InitLSym(f *ir.Func, hasBody bool) { // the funcsym for either the defining // function or its wrapper as appropriate. // - // If we're using ABI aliases instead of - // wrappers, we only InitLSym for the defining - // ABI of a function, so we make the funcsym - // when we see that. + // If we're not using ABI wrappers, we only + // InitLSym for the defining ABI of a function, + // so we make the funcsym when we see that. staticdata.NeedFuncSym(f) } } diff --git a/src/cmd/compile/internal/staticdata/data.go b/src/cmd/compile/internal/staticdata/data.go index f25d8d8ec5..57c15a34a0 100644 --- a/src/cmd/compile/internal/staticdata/data.go +++ b/src/cmd/compile/internal/staticdata/data.go @@ -279,7 +279,7 @@ func NeedFuncSym(fn *ir.Func) { // entry points, so it doesn't make sense to create a // funcsym for other ABIs. // - // (If we're using ABI aliases, it doesn't matter.) + // (If we're not using ABI wrappers, it doesn't matter.) base.Fatalf("expected ABIInternal: %v has %v", fn.Nname, fn.ABI) } if ir.IsBlank(fn.Nname) {