From: Keith Randall <khr@golang.org>
Date: Tue, 27 Jul 2021 02:37:10 +0000 (-0700)
Subject: [dev.typeparams] cmd/compile: don't need to unshapify append calls
X-Git-Tag: go1.18beta1~1818^2^2~95
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5d8f90f904;p=gostls13.git

[dev.typeparams] cmd/compile: don't need to unshapify append calls

append is fine using shape types.

Change-Id: Iae829b9b5929d4dc7aa74bed57da13d4f6d746be
Reviewed-on: https://go-review.googlesource.com/c/go/+/337669
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
---

diff --git a/src/cmd/compile/internal/noder/stencil.go b/src/cmd/compile/internal/noder/stencil.go
index 575b879762..e482281a3c 100644
--- a/src/cmd/compile/internal/noder/stencil.go
+++ b/src/cmd/compile/internal/noder/stencil.go
@@ -1291,13 +1291,6 @@ func (subst *subster) node(n ir.Node) ir.Node {
 					default:
 						base.FatalfAt(call.Pos(), "Unexpected builtin op")
 					}
-					switch m.Op() {
-					case ir.OAPPEND:
-						// Append needs to pass a concrete type to the runtime.
-						// TODO: there's no way to record a dictionary-loaded type for walk to use here
-						m.SetType(subst.unshapifyTyp(m.Type()))
-					}
-
 				} else {
 					// This is the case of a function value that was a
 					// type parameter (implied to be a function via a