From: qmuntal Date: Tue, 5 Mar 2024 14:55:27 +0000 (+0100) Subject: os: fix 63703.md release notes X-Git-Tag: go1.23rc1~997 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5e387b2feee87b7d8d5cc81e7cb08603b3e9cd6a;p=gostls13.git os: fix 63703.md release notes 63703.md contains a paragraph that shouldn't be there, remove it. While here, fix a test error message related to the #63703 implementation. Updates #63703. Change-Id: I82a8b0b7dfa8f96530fb9a3a3aa971e03970f168 Reviewed-on: https://go-review.googlesource.com/c/go/+/569195 Reviewed-by: Michael Knyszek Reviewed-by: Bryan Mills LUCI-TryBot-Result: Go LUCI --- diff --git a/doc/next/6-stdlib/99-minor/os/63703.md b/doc/next/6-stdlib/99-minor/os/63703.md index 581ea142ab..abde9448f5 100644 --- a/doc/next/6-stdlib/99-minor/os/63703.md +++ b/doc/next/6-stdlib/99-minor/os/63703.md @@ -1,10 +1,4 @@ -On Windows, the [`os.Readlink`](/os#Readlink) function no longer tries -to resolve mount points to a canonical path. -This behavior is controlled by the `winsymlink` setting. -For Go 1.23, it defaults to `winsymlink=1`. -Previous versions default to `winsymlink=0`. - -On Windows, [`os.Readlink`](/pkg/path/filepath#EvalSymlinks) no longer tries +On Windows, [`os.Readlink`](/os#Readlink) no longer tries to normalize volumes to drive letters, which was not always even possible. This behavior is controlled by the `winreadlinkvolume` setting. For Go 1.23, it defaults to `winreadlinkvolume=1`. diff --git a/src/os/os_windows_test.go b/src/os/os_windows_test.go index 7e8b8bbf1f..956ab07f51 100644 --- a/src/os/os_windows_test.go +++ b/src/os/os_windows_test.go @@ -172,7 +172,7 @@ func testDirLinks(t *testing.T, tests []dirLinkTest) { wantType = fs.ModeSymlink } if tp := fi2.Mode().Type(); tp != wantType { - t.Errorf("Lstat(%q) is type %v; want %v", link, tp, fs.ModeDir) + t.Errorf("Lstat(%q) is type %v; want %v", link, tp, wantType) } } }