From: Yury Smolsky <yury@smolsky.by>
Date: Thu, 7 Jun 2018 21:25:12 +0000 (+0300)
Subject: cmd/compile: use expandable columns in ssa.html
X-Git-Tag: go1.11beta1~111
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5eb98b3c3016c7dd10d71ee15bb6fc5d3128bec9;p=gostls13.git

cmd/compile: use expandable columns in ssa.html

Display just a few columns in ssa.html, other
columns can be expanded by clicking on collapsed column.

Use sans serif font for the text, slightly smaller font size
for non program text.

Fixes #25286

Change-Id: I1094695135401602d90b97b69e42f6dda05871a2
Reviewed-on: https://go-review.googlesource.com/117275
Run-TryBot: Yury Smolsky <yury@smolsky.by>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
---

diff --git a/src/cmd/compile/internal/gc/ssa.go b/src/cmd/compile/internal/gc/ssa.go
index a64d212233..3c15c8e555 100644
--- a/src/cmd/compile/internal/gc/ssa.go
+++ b/src/cmd/compile/internal/gc/ssa.go
@@ -4985,7 +4985,7 @@ func genssa(f *ssa.Func, pp *Progs) {
 			}
 			buf.WriteString("</dl>")
 			buf.WriteString("</code>")
-			f.HTMLWriter.WriteColumn("genssa", "ssa-prog", buf.String())
+			f.HTMLWriter.WriteColumn("genssa", "genssa", "ssa-prog", buf.String())
 			// pp.Text.Ctxt.LineHist.PrintFilenameOnly = saved
 		}
 	}
diff --git a/src/cmd/compile/internal/ssa/compile.go b/src/cmd/compile/internal/ssa/compile.go
index 4bd9ade479..c7797d79e9 100644
--- a/src/cmd/compile/internal/ssa/compile.go
+++ b/src/cmd/compile/internal/ssa/compile.go
@@ -43,7 +43,7 @@ func Compile(f *Func) {
 
 	// Run all the passes
 	printFunc(f)
-	f.HTMLWriter.WriteFunc("start", f)
+	f.HTMLWriter.WriteFunc("start", "start", f)
 	if BuildDump != "" && BuildDump == f.Name {
 		f.dumpFile("build")
 	}
@@ -86,7 +86,7 @@ func Compile(f *Func) {
 
 			f.Logf("  pass %s end %s\n", p.name, stats)
 			printFunc(f)
-			f.HTMLWriter.WriteFunc(fmt.Sprintf("after %s <span class=\"stats\">%s</span>", phaseName, stats), f)
+			f.HTMLWriter.WriteFunc(phaseName, fmt.Sprintf("%s <span class=\"stats\">%s</span>", phaseName, stats), f)
 		}
 		if p.time || p.mem {
 			// Surround timing information w/ enough context to allow comparisons.
diff --git a/src/cmd/compile/internal/ssa/html.go b/src/cmd/compile/internal/ssa/html.go
index 85d97ba497..d37e69977e 100644
--- a/src/cmd/compile/internal/ssa/html.go
+++ b/src/cmd/compile/internal/ssa/html.go
@@ -38,6 +38,11 @@ func (w *HTMLWriter) start(name string) {
 <meta http-equiv="Content-Type" content="text/html;charset=UTF-8">
 <style>
 
+body {
+    font-size: 14px;
+    font-family: Arial, sans-serif;
+}
+
 #helplink {
     margin-bottom: 15px;
     display: block;
@@ -66,6 +71,32 @@ th, td {
     padding: 5px;
 }
 
+td > h2 {
+    cursor: pointer;
+    font-size: 120%;
+}
+
+td.collapsed {
+    font-size: 12px;
+    width: 12px;
+    border: 0px;
+    padding: 0;
+    cursor: pointer;
+    background: #fafafa;
+}
+
+td.collapsed  div {
+     -moz-transform: rotate(-90.0deg);  /* FF3.5+ */
+       -o-transform: rotate(-90.0deg);  /* Opera 10.5 */
+  -webkit-transform: rotate(-90.0deg);  /* Saf3.1+, Chrome */
+             filter:  progid:DXImageTransform.Microsoft.BasicImage(rotation=0.083);  /* IE6,IE7 */
+         -ms-filter: "progid:DXImageTransform.Microsoft.BasicImage(rotation=0.083)"; /* IE8 */
+         margin-top: 10.3em;
+         margin-left: -10em;
+         margin-right: -10em;
+         text-align: right;
+}
+
 td.ssa-prog {
     width: 600px;
     word-wrap: break-word;
@@ -263,6 +294,56 @@ window.onload = function() {
     for (var i = 0; i < ssablocks.length; i++) {
         ssablocks[i].addEventListener('click', ssaBlockClicked);
     }
+   var expandedDefault = [
+        "start",
+        "deadcode",
+        "opt",
+        "lower",
+        "late deadcode",
+        "regalloc",
+        "genssa",
+    ]
+    function isExpDefault(id) {
+        for (var i = 0; i < expandedDefault.length; i++) {
+            if (id.startsWith(expandedDefault[i])) {
+                return true;
+            }
+        }
+        return false;
+    }
+    function toggler(phase) {
+        return function() {
+            toggle_cell(phase+'-col');
+            toggle_cell(phase+'-exp');
+        };
+    }
+    function toggle_cell(id) {
+       var e = document.getElementById(id);
+       if(e.style.display == 'table-cell')
+          e.style.display = 'none';
+       else
+          e.style.display = 'table-cell';
+    }
+
+    var td = document.getElementsByTagName("td");
+    for (var i = 0; i < td.length; i++) {
+        var id = td[i].id;
+        var def = isExpDefault(id);
+        var phase = id.substr(0, id.length-4);
+        if (id.endsWith("-exp")) {
+            var h2 = td[i].getElementsByTagName("h2");
+            if (h2 && h2[0]) {
+                h2[0].addEventListener('click', toggler(phase));
+            }
+        } else {
+	        td[i].addEventListener('click', toggler(phase));
+        }
+        if (id.endsWith("-col") && def || id.endsWith("-exp") && !def) {
+               td[i].style.display = 'none';
+               continue
+        }
+        td[i].style.display = 'table-cell';
+    }
 };
 
 function toggle_visibility(id) {
@@ -316,24 +397,28 @@ func (w *HTMLWriter) Close() {
 }
 
 // WriteFunc writes f in a column headed by title.
-func (w *HTMLWriter) WriteFunc(title string, f *Func) {
+func (w *HTMLWriter) WriteFunc(phase, title string, f *Func) {
 	if w == nil {
 		return // avoid generating HTML just to discard it
 	}
-	w.WriteColumn(title, "", f.HTML())
+	w.WriteColumn(phase, title, "", f.HTML())
 	// TODO: Add visual representation of f's CFG.
 }
 
 // WriteColumn writes raw HTML in a column headed by title.
 // It is intended for pre- and post-compilation log output.
-func (w *HTMLWriter) WriteColumn(title, class, html string) {
+func (w *HTMLWriter) WriteColumn(phase, title, class, html string) {
 	if w == nil {
 		return
 	}
+	id := strings.Replace(phase, " ", "-", -1)
+	// collapsed column
+	w.Printf("<td id=\"%v-col\" class=\"collapsed\"><div>%v</div></td>", id, phase)
+
 	if class == "" {
-		w.WriteString("<td>")
+		w.Printf("<td id=\"%v-exp\">", id)
 	} else {
-		w.WriteString("<td class=\"" + class + "\">")
+		w.Printf("<td id=\"%v-exp\" class=\"%v\">", id, class)
 	}
 	w.WriteString("<h2>" + title + "</h2>")
 	w.WriteString(html)