From: Roger Peppe <rogpeppe@gmail.com>
Date: Thu, 5 Jan 2012 21:19:25 +0000 (-0800)
Subject: go test: don't try to print package with error message.
X-Git-Tag: weekly.2012-01-15~144
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5f5a7eb4bc6160a99ec3656ab87351aa1299341c;p=gostls13.git

go test: don't try to print package with error message.
If there's a error compiling a _test.go file, the error
message tries to print a *Package with %s. There's no String
method on *Package, so the error message looks bad.
Since the error messages identify the file in question
anyway, this CL removes the package from the error message.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5520045
---

diff --git a/src/cmd/go/test.go b/src/cmd/go/test.go
index 1807e42f72..fb0ba7b4d0 100644
--- a/src/cmd/go/test.go
+++ b/src/cmd/go/test.go
@@ -228,7 +228,7 @@ func runTest(cmd *Command, args []string) {
 	for _, p := range pkgs {
 		buildTest, runTest, err := b.test(p)
 		if err != nil {
-			errorf("%s: %s", p, err)
+			errorf("%s", err)
 			continue
 		}
 		builds = append(builds, buildTest)