From: guoguangwu Date: Thu, 21 Mar 2024 08:15:08 +0000 (+0000) Subject: encoding/gob: close files used in dump.go and encgen.go X-Git-Tag: go1.23rc1~792 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5f5b20c4268c1a3aa6a3b132aeede6dc82adf344;p=gostls13.git encoding/gob: close files used in dump.go and encgen.go Change-Id: Ic1dd899fa52fdf9098955fc14a828d2f07da8037 GitHub-Last-Rev: 6e0438ec7178382e2a7d56f0a053cec33fbe9e78 GitHub-Pull-Request: golang/go#66437 Reviewed-on: https://go-review.googlesource.com/c/go/+/573235 TryBot-Result: Gopher Robot Reviewed-by: David Chase Reviewed-by: Ian Lance Taylor LUCI-TryBot-Result: Go LUCI Run-TryBot: Rob Pike Auto-Submit: Ian Lance Taylor Reviewed-by: Rob Pike --- diff --git a/src/encoding/gob/dump.go b/src/encoding/gob/dump.go index f4b1bebfba..b14d84164b 100644 --- a/src/encoding/gob/dump.go +++ b/src/encoding/gob/dump.go @@ -24,6 +24,7 @@ func main() { fmt.Fprintf(os.Stderr, "dump: %s\n", err) os.Exit(1) } + defer file.Close() } gob.Debug(file) } diff --git a/src/encoding/gob/encgen.go b/src/encoding/gob/encgen.go index e5f68786a0..64f5c69bd4 100644 --- a/src/encoding/gob/encgen.go +++ b/src/encoding/gob/encgen.go @@ -170,6 +170,9 @@ func main() { if _, err := fd.Write(source); err != nil { log.Fatal(err) } + if err := fd.Close(); err != nil { + log.Fatal(err) + } } func printMaps(b *bytes.Buffer, upperClass string) {