From: Martin Möhrmann <moehrmann@google.com>
Date: Mon, 10 Jun 2019 10:56:59 +0000 (+0200)
Subject: runtime: reduce allocations when building pprof LabelSet
X-Git-Tag: go1.14beta1~1317
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=5fb74fc13853b950b5102ef26d665db97f4838fd;p=gostls13.git

runtime: reduce allocations when building pprof LabelSet

Pre-allocate the slice of labels with enough capacity
to avoid growslice calls.

Change-Id: I89db59ac722c03b0202e042d1f707bb041e0999f
Reviewed-on: https://go-review.googlesource.com/c/go/+/181517
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
---

diff --git a/src/runtime/pprof/label.go b/src/runtime/pprof/label.go
index 20f9cdbae6..2d92ef7e8a 100644
--- a/src/runtime/pprof/label.go
+++ b/src/runtime/pprof/label.go
@@ -60,11 +60,11 @@ func Labels(args ...string) LabelSet {
 	if len(args)%2 != 0 {
 		panic("uneven number of arguments to pprof.Labels")
 	}
-	labels := LabelSet{}
+	list := make([]label, 0, len(args)/2)
 	for i := 0; i+1 < len(args); i += 2 {
-		labels.list = append(labels.list, label{key: args[i], value: args[i+1]})
+		list = append(list, label{key: args[i], value: args[i+1]})
 	}
-	return labels
+	return LabelSet{list: list}
 }
 
 // Label returns the value of the label with the given key on ctx, and a boolean indicating