From: Nick Ripley <nick.ripley@datadoghq.com>
Date: Wed, 19 Apr 2023 18:42:30 +0000 (-0400)
Subject: runtime: turn frame pointer unwinding for tracing off by default
X-Git-Tag: go1.21rc1~824
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=608f204ac79455bee144d6fa93162991bdb46b61;p=gostls13.git

runtime: turn frame pointer unwinding for tracing off by default

Frame pointer unwinding during execution tracing sometimes crashes.
Until this is diagnosed and fixed, it should be turned off by default.

Updates #59692

Change-Id: I0f2ca24b6d48435b0acfd3da8e4f25b9cfa4ec19
Reviewed-on: https://go-review.googlesource.com/c/go/+/486382
Reviewed-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Nick Ripley <nick.ripley@datadoghq.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
---

diff --git a/src/runtime/runtime1.go b/src/runtime/runtime1.go
index 98c5c84c01..021dfb8b55 100644
--- a/src/runtime/runtime1.go
+++ b/src/runtime/runtime1.go
@@ -369,6 +369,7 @@ func parsedebugvars() {
 	debug.cgocheck = 1
 	debug.invalidptr = 1
 	debug.adaptivestackstart = 1 // set this to 0 to turn larger initial goroutine stacks off
+	debug.tracefpunwindoff = 1   // Frame pointer unwinding sometimes crashes on amd64. See issue 59692.
 	if GOOS == "linux" {
 		// On Linux, MADV_FREE is faster than MADV_DONTNEED,
 		// but doesn't affect many of the statistics that