From: Russ Cox Date: Sat, 4 Nov 2017 17:14:19 +0000 (-0400) Subject: cmd/go: do not print entire help text for unrecognized flag X-Git-Tag: go1.10beta1~388 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=60a3c95dcb7ba40994a41baf48d64f2fae1c2313;p=gostls13.git cmd/go: do not print entire help text for unrecognized flag I typed 'go list -josn' without realizing I'd mistyped json, and I was confused for quite a while as to why I was staring at the 'go help json' text: the actual problem (a missing flag) scrolls far off the screen. If people want the full text, they can easily ask for it, but don't drown the important bit - unrecognized flag or other improper usage - with pages of supporting commentary. The help text does not help people who just need to be told about a typo. Change-Id: I179c431baa831e330f3ee495ce0a5369319962d5 Reviewed-on: https://go-review.googlesource.com/76013 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- diff --git a/src/cmd/go/internal/base/base.go b/src/cmd/go/internal/base/base.go index aff33f70d8..286efbc041 100644 --- a/src/cmd/go/internal/base/base.go +++ b/src/cmd/go/internal/base/base.go @@ -62,8 +62,8 @@ func (c *Command) Name() string { } func (c *Command) Usage() { - fmt.Fprintf(os.Stderr, "usage: %s\n\n", c.UsageLine) - fmt.Fprintf(os.Stderr, "%s\n", strings.TrimSpace(c.Long)) + fmt.Fprintf(os.Stderr, "usage: %s\n", c.UsageLine) + fmt.Fprintf(os.Stderr, "Run 'go help %s' for details.\n", c.Name()) os.Exit(2) }