From: Ian Lance Taylor <iant@golang.org>
Date: Tue, 21 Jan 2014 14:12:54 +0000 (-0800)
Subject: liblink: check for symgrow size too large
X-Git-Tag: go1.3beta1~920
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=6111dc4e71ffd843ac8029df4fd67d32689f8e36;p=gostls13.git

liblink: check for symgrow size too large

Many calls to symgrow pass a vlong value.  Change the function
to not implicitly truncate, and to instead give an error if
the value is too large.

R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://golang.org/cl/54010043
---

diff --git a/include/link.h b/include/link.h
index 2e23d20c7c..32d158428d 100644
--- a/include/link.h
+++ b/include/link.h
@@ -500,7 +500,7 @@ vlong	setuint32(Link *ctxt, LSym *s, vlong r, uint32 v);
 vlong	setuint64(Link *ctxt, LSym *s, vlong r, uint64 v);
 vlong	setuint8(Link *ctxt, LSym *s, vlong r, uint8 v);
 vlong	setuintxx(Link *ctxt, LSym *s, vlong off, uint64 v, vlong wid);
-void	symgrow(Link *ctxt, LSym *s, int32 siz);
+void	symgrow(Link *ctxt, LSym *s, vlong siz);
 
 // go.c
 void	double2ieee(uint64 *ieee, double native);
diff --git a/src/liblink/data.c b/src/liblink/data.c
index 9a481b6e5e..58d6d6b5e8 100644
--- a/src/liblink/data.c
+++ b/src/liblink/data.c
@@ -41,10 +41,16 @@ mangle(char *file)
 }
 
 void
-symgrow(Link *ctxt, LSym *s, int32 siz)
+symgrow(Link *ctxt, LSym *s, vlong lsiz)
 {
+	int32 siz;
+
 	USED(ctxt);
 
+	siz = (int32)lsiz;
+	if((vlong)siz != lsiz)
+		sysfatal("symgrow size %lld too long", lsiz);
+
 	if(s->np >= siz)
 		return;