From: Heschi Kreinick Date: Mon, 6 Dec 2021 22:45:38 +0000 (-0500) Subject: [release-branch.go1.17] misc/cgo/testplugin: skip TestIssue25756pie on darwin/arm64... X-Git-Tag: go1.17.5~4 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=61317ef99e015600704ee580a370f356f1bb4a6b;p=gostls13.git [release-branch.go1.17] misc/cgo/testplugin: skip TestIssue25756pie on darwin/arm64 builder Repeat of CL 321349 for macOS 12. We won't need to do this again -- the test is passing at tip. Updates #46239. Change-Id: Ib279ada443ee03eb8e70fde4bbfba65ce0f6322e Reviewed-on: https://go-review.googlesource.com/c/go/+/369748 Trust: Heschi Kreinick Reviewed-by: Dmitri Shuralyov Run-TryBot: Heschi Kreinick TryBot-Result: Gopher Robot --- diff --git a/misc/cgo/testplugin/plugin_test.go b/misc/cgo/testplugin/plugin_test.go index 9697dbf7a7..ba4dd4cc4c 100644 --- a/misc/cgo/testplugin/plugin_test.go +++ b/misc/cgo/testplugin/plugin_test.go @@ -265,7 +265,7 @@ func TestIssue25756(t *testing.T) { // Test with main using -buildmode=pie with plugin for issue #43228 func TestIssue25756pie(t *testing.T) { - if os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-11_0-toothrot" { + if os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-11_0-toothrot" || os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-12_0-toothrot" { t.Skip("broken on darwin/arm64 builder in sharded mode; see issue 46239") }