From: Jes Cok <xigua67damn@gmail.com>
Date: Sat, 26 Jul 2025 02:49:42 +0000 (+0000)
Subject: errors: omit redundant nil check in type assertion for Join
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=64ba72474d9a637fc8152c3bbd8cdec3ffde2940;p=gostls13.git

errors: omit redundant nil check in type assertion for Join

When ok is true, err can't be nil.

Make it behave more like the Unwrap function.

Change-Id: Ieba5de57d60f5ff4d6a3468d703e6f72be02a97d
GitHub-Last-Rev: 6df9365a1d586bba64df57be11f9ca7b772cc773
GitHub-Pull-Request: golang/go#74764
Reviewed-on: https://go-review.googlesource.com/c/go/+/689920
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Mark Freeman <mark@golang.org>
Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
---

diff --git a/src/errors/join.go b/src/errors/join.go
index dd50089c29..d0a1bc298e 100644
--- a/src/errors/join.go
+++ b/src/errors/join.go
@@ -28,12 +28,10 @@ func Join(errs ...error) error {
 	}
 	if n == 1 {
 		for _, err := range errs {
-			if err != nil {
-				if _, ok := err.(interface {
-					Unwrap() []error
-				}); ok {
-					return err
-				}
+			if _, ok := err.(interface {
+				Unwrap() []error
+			}); ok {
+				return err
 			}
 		}
 	}