From: Rob Pike <r@golang.org>
Date: Sun, 29 Aug 2010 22:03:06 +0000 (+1000)
Subject: rpc: fix bug that caused private methods to attempt to be registered.
X-Git-Tag: weekly.2010-09-06~55
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=64cb9b6f4559e7aa4320e9fe8650433a6548d606;p=gostls13.git

rpc: fix bug that caused private methods to attempt to be registered.

Fixes #1056.

R=golang-dev, adg1
CC=golang-dev
https://golang.org/cl/2033043
---

diff --git a/src/pkg/rpc/server.go b/src/pkg/rpc/server.go
index d14f6ded2c..91b88e23de 100644
--- a/src/pkg/rpc/server.go
+++ b/src/pkg/rpc/server.go
@@ -211,7 +211,7 @@ func (server *serverType) register(rcvr interface{}) os.Error {
 		method := s.typ.Method(m)
 		mtype := method.Type
 		mname := method.Name
-		if mtype.PkgPath() != "" && !isPublic(mname) {
+		if mtype.PkgPath() != "" || !isPublic(mname) {
 			continue
 		}
 		// Method needs three ins: receiver, *args, *reply.