From: Daniel Martí <mvdan@mvdan.cc>
Date: Sat, 23 Sep 2017 11:22:10 +0000 (+0100)
Subject: cmd/compile: clarify adjustctxt inlining comment
X-Git-Tag: go1.10beta1~1004
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=6936671ed1c3a1dd25e0eea635ee2bdc86acd463;p=gostls13.git

cmd/compile: clarify adjustctxt inlining comment

The reason why adjustctxt wasn't being inlined was reported as:

	function too complex: cost 92 exceeds budget 80

However, after tweaking the code to be under the budget limit, we see
the real blocker:

	non-leaf function

There is little we can do about this one in particular at the moment.
Create a section with funcs that will need mid-stack inlining to be
inlineable, since this will likely come up again in other cases.

Change-Id: I3a8eb1546b289a060ac896506a007b0496946e84
Reviewed-on: https://go-review.googlesource.com/65650
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
---

diff --git a/src/cmd/compile/internal/gc/inl_test.go b/src/cmd/compile/internal/gc/inl_test.go
index cbcd96a7b9..a0f466580a 100644
--- a/src/cmd/compile/internal/gc/inl_test.go
+++ b/src/cmd/compile/internal/gc/inl_test.go
@@ -29,6 +29,10 @@ func TestIntendedInlining(t *testing.T) {
 	// be inlined.
 	want := map[string][]string{
 		"runtime": {
+			// TODO(mvdan): enable these once mid-stack
+			// inlining is available
+			// "adjustctxt",
+
 			"add",
 			"addb",
 			"adjustpanics",
@@ -58,8 +62,6 @@ func TestIntendedInlining(t *testing.T) {
 			"(*bmap).keys",
 			"(*bmap).overflow",
 			"(*waitq).enqueue",
-
-			//"adjustctxt", TODO(mvdan): fix and re-enable
 		},
 		"runtime/internal/sys": {},
 		"unicode/utf8": {