From: Keith Randall Date: Thu, 16 May 2019 23:16:26 +0000 (-0700) Subject: cmd/compile: mention issue 28603 when discussing where inline marks go X-Git-Tag: go1.13beta1~266 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=6c842cc610bff3e025236dfe4ececbdf91aa66e3;p=gostls13.git cmd/compile: mention issue 28603 when discussing where inline marks go Update #28603 Change-Id: I8bdbea57b3661e15dcc760d27252b794daa476db Reviewed-on: https://go-review.googlesource.com/c/go/+/177697 Reviewed-by: Emmanuel Odeke --- diff --git a/src/cmd/compile/internal/gc/inl.go b/src/cmd/compile/internal/gc/inl.go index addba98e3e..b41b8cb1a4 100644 --- a/src/cmd/compile/internal/gc/inl.go +++ b/src/cmd/compile/internal/gc/inl.go @@ -1046,10 +1046,11 @@ func mkinlcall(n, fn *Node, maxCost int32) *Node { } newIndex := Ctxt.InlTree.Add(parent, n.Pos, fn.Sym.Linksym()) - // Add a inline mark just before the inlined body. + // Add an inline mark just before the inlined body. // This mark is inline in the code so that it's a reasonable spot // to put a breakpoint. Not sure if that's really necessary or not // (in which case it could go at the end of the function instead). + // Note issue 28603. inlMark := nod(OINLMARK, nil, nil) inlMark.Pos = n.Pos.WithIsStmt() inlMark.Xoffset = int64(newIndex)