From: Rob Findley Date: Tue, 23 Feb 2021 16:48:15 +0000 (-0500) Subject: go/types: minor updates to comments to align with types2 X-Git-Tag: go1.17beta1~1408 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=6cc8aa7ece;p=gostls13.git go/types: minor updates to comments to align with types2 Change-Id: Ic4fcd67cd9222eae6b72d9e91e37f3b0293b0b8d Reviewed-on: https://go-review.googlesource.com/c/go/+/295530 Reviewed-by: Robert Griesemer Trust: Robert Findley Run-TryBot: Robert Findley TryBot-Result: Go Bot --- diff --git a/src/go/types/conversions.go b/src/go/types/conversions.go index 69463f0ca6..d93ff465bb 100644 --- a/src/go/types/conversions.go +++ b/src/go/types/conversions.go @@ -142,7 +142,7 @@ func isUintptr(typ Type) bool { } func isUnsafePointer(typ Type) bool { - // TODO(gri): Is this asBasic() instead of typ.(*Basic) correct? + // TODO(gri): Is this asBasic(typ) instead of typ.(*Basic) correct? // (The former calls under(), while the latter doesn't.) // The spec does not say so, but gc claims it is. See also // issue 6326. diff --git a/src/go/types/issues_test.go b/src/go/types/issues_test.go index 9ed2934c74..a773a362c7 100644 --- a/src/go/types/issues_test.go +++ b/src/go/types/issues_test.go @@ -385,9 +385,9 @@ func TestIssue28005(t *testing.T) { } } if obj == nil { - t.Fatal("interface not found") + t.Fatal("object X not found") } - iface := obj.Type().Underlying().(*Interface) // I must be an interface + iface := obj.Type().Underlying().(*Interface) // object X must be an interface // Each iface method m is embedded; and m's receiver base type name // must match the method's name per the choice in the source file.