From: Hiroshi Ioka <hirochachacha@gmail.com>
Date: Tue, 22 Aug 2017 10:50:43 +0000 (+0900)
Subject: cmd/link: avoid leaking file in ldshlibsyms
X-Git-Tag: go1.10beta1~1343
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=6eef2bb5eeb4831a4d61dc2ffb14772e1270e634;p=gostls13.git

cmd/link: avoid leaking file in ldshlibsyms

Change-Id: If27f7fbf94ede6f9a57f2520aaf75e6506e0b3f8
Reviewed-on: https://go-review.googlesource.com/59374
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
---

diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go
index 3207bdb837..4538899fa0 100644
--- a/src/cmd/link/internal/ld/lib.go
+++ b/src/cmd/link/internal/ld/lib.go
@@ -1562,6 +1562,7 @@ func ldshlibsyms(ctxt *Link, shlib string) {
 		Errorf(nil, "cannot open shared library: %s", libpath)
 		return
 	}
+	defer f.Close()
 
 	hash, err := readnote(f, ELF_NOTE_GO_NAME, ELF_NOTE_GOABIHASH_TAG)
 	if err != nil {