From: Michael Pratt Date: Thu, 18 May 2023 17:12:26 +0000 (+0000) Subject: Revert "cmd/compile: build compiler with PGO" X-Git-Tag: go1.21rc1~460 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=6ffd135256fddc4963a91ee0f6cd7f08ed43e43e;p=gostls13.git Revert "cmd/compile: build compiler with PGO" This reverts CL 495596. Reason for revert: duplicate symbol failures in x/tools and random PPC crashes. Change-Id: I57305f8e72ee1567dc5a6a829c2d70fb5719028a Reviewed-on: https://go-review.googlesource.com/c/go/+/496185 Reviewed-by: Bryan Mills Run-TryBot: Michael Pratt Auto-Submit: Michael Pratt TryBot-Result: Gopher Robot --- diff --git a/src/cmd/compile/default.pgo b/src/cmd/compile/default.pgo deleted file mode 100644 index 2ba79688d4..0000000000 Binary files a/src/cmd/compile/default.pgo and /dev/null differ diff --git a/src/cmd/compile/profile.sh b/src/cmd/compile/profile.sh deleted file mode 100644 index 37d65d8494..0000000000 --- a/src/cmd/compile/profile.sh +++ /dev/null @@ -1,21 +0,0 @@ -# Copyright 2023 The Go Authors. All rights reserved. -# Use of this source code is governed by a BSD-style -# license that can be found in the LICENSE file. - -# This script collects a CPU profile of the compiler -# for building all targets in std and cmd, and puts -# the profile at cmd/compile/default.pgo. - -dir=$(mktemp -d) -cd $dir -seed=$(date) - -for p in $(go list std cmd); do - h=$(echo $seed $p | md5sum | cut -d ' ' -f 1) - echo $p $h - go build -o /dev/null -gcflags=-cpuprofile=$PWD/prof.$h $p -done - -go tool pprof -proto prof.* > $(go env GOROOT)/src/cmd/compile/default.pgo - -rm -r $dir diff --git a/src/cmd/dist/buildtool.go b/src/cmd/dist/buildtool.go index 7ecfb3a811..af3db5f590 100644 --- a/src/cmd/dist/buildtool.go +++ b/src/cmd/dist/buildtool.go @@ -100,10 +100,6 @@ var ignorePrefixes = []string{ var ignoreSuffixes = []string{ "_test.s", "_test.go", - // Skip PGO profile. No need to build toolchain1 compiler - // with PGO. And as it is not a text file the import path - // rewrite will break it. - ".pgo", } var tryDirs = []string{