From: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Date: Thu, 22 Jul 2021 17:24:50 +0000 (+0700)
Subject: [dev.typeparams] cmd/compile: remove outdate TODO in escape analysis
X-Git-Tag: go1.18beta1~1818^2^2~116
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=73162a54c2885d32d40067d2e4fbe26bbe5c7d65;p=gostls13.git

[dev.typeparams] cmd/compile: remove outdate TODO in escape analysis

We now understand the root cause of #47227, it will be fixed in #47317.

Change-Id: Ifcd44f887a0bd3195818df33e409bd3e818e0b27
Reviewed-on: https://go-review.googlesource.com/c/go/+/336610
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
---

diff --git a/src/cmd/compile/internal/escape/call.go b/src/cmd/compile/internal/escape/call.go
index 65c76d6870..9e5abed591 100644
--- a/src/cmd/compile/internal/escape/call.go
+++ b/src/cmd/compile/internal/escape/call.go
@@ -320,8 +320,6 @@ func (e *escape) rewriteArgument(argp *ir.Node, init *ir.Nodes, call ir.Node, fn
 			return
 		case ir.ONAME:
 			if arg.(*ir.Name).Class == ir.PFUNC {
-				// TODO(cuonglm): figure it why this is necessary, we should not depend on this to make
-				//                ABI analyze works correctly (see #47227 and discussion in CL 334882).
 				return
 			}
 		}