From: Russ Cox <rsc@golang.org>
Date: Fri, 17 Aug 2018 14:54:20 +0000 (-0400)
Subject: cmd/go: document import "C" check from CL 129062
X-Git-Tag: go1.11rc2~8^2~21
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=751ea9369a9bd3b30daafced4d1c172541076617;p=gostls13.git

cmd/go: document import "C" check from CL 129062

Added this locally but then broke the first rule of Gerrit
and clicked Submit instead of running "git submit".

Change-Id: I83c28d9151c566e9b2092e2613d67731a5d64beb
Reviewed-on: https://go-review.googlesource.com/129678
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
---

diff --git a/src/cmd/go/internal/imports/scan.go b/src/cmd/go/internal/imports/scan.go
index bae6b934bc..d944e95724 100644
--- a/src/cmd/go/internal/imports/scan.go
+++ b/src/cmd/go/internal/imports/scan.go
@@ -49,12 +49,19 @@ Files:
 		if err != nil {
 			return nil, nil, fmt.Errorf("reading %s: %v", name, err)
 		}
-		// import "C" is implicit requirement of cgo tag
+
+		// import "C" is implicit requirement of cgo tag.
+		// When listing files on the command line (explicitFiles=true)
+		// we do not apply build tag filtering but we still do apply
+		// cgo filtering, so no explicitFiles check here.
+		// Why? Because we always have, and it's not worth breaking
+		// that behavior now.
 		for _, path := range list {
 			if path == `"C"` && !tags["cgo"] && !tags["*"] {
 				continue Files
 			}
 		}
+
 		if !explicitFiles && !ShouldBuild(data, tags) {
 			continue
 		}