From: Ian Lance Taylor Date: Thu, 9 Jun 2016 00:45:55 +0000 (-0700) Subject: cmd/go: only run TestGoGetHTTPS404 where it works X-Git-Tag: go1.7beta2~36 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=763883632e4d7fea145b6f3a7ee501b5ad9096f2;p=gostls13.git cmd/go: only run TestGoGetHTTPS404 where it works The test TestGoGetHTTPS404 downloads a package that does not build on every OS, so change it to only run where the package builds. It's not great for the test to depend on an external package, but this is an improvement on the current situation. Fixes #15644. Change-Id: I1679cee5ab1e61a5b26f4ad39dc8a397fbc0da69 Reviewed-on: https://go-review.googlesource.com/23920 Run-TryBot: Ian Lance Taylor Reviewed-by: Andrew Gerrand --- diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index 1bee5e6609..c46e0c7da5 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -2358,6 +2358,11 @@ func TestGoGetRscIoToolstash(t *testing.T) { // Issue 13037: Was not parsing tags in 404 served over HTTPS func TestGoGetHTTPS404(t *testing.T) { testenv.MustHaveExternalNetwork(t) + switch runtime.GOOS { + case "darwin", "linux", "freebsd": + default: + t.Skipf("test case does not work on %s", runtime.GOOS) + } tg := testgo(t) defer tg.cleanup()