From: Austin Clements Date: Fri, 26 May 2023 01:43:33 +0000 (-0400) Subject: runtime: delete a very stale comment X-Git-Tag: go1.21rc1~213 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=76bb0caa5cf76bf631bb6cfd5c0853305087dc78;p=gostls13.git runtime: delete a very stale comment This comment claims mark termination re-scans stacks and uses the write barrier to determine how much of the stack needs to be rescanned. This hasn't been true since we introduced the hybrid write barrier and deleted stack rescanning with CL 31766 in Go 1.8. Updates #17503 I suppose. Change-Id: I5e90f25020c9fa6f146ec6ed0642ba2b4884c2a8 Reviewed-on: https://go-review.googlesource.com/c/go/+/498435 Reviewed-by: Michael Knyszek Auto-Submit: Michael Knyszek TryBot-Result: Gopher Robot Run-TryBot: Michael Knyszek --- diff --git a/src/runtime/mbarrier.go b/src/runtime/mbarrier.go index 4bcc170ef9..159a298155 100644 --- a/src/runtime/mbarrier.go +++ b/src/runtime/mbarrier.go @@ -112,12 +112,6 @@ import ( // compiler will generate a write barrier for writes through that // pointer (because it doesn't know it's not a heap pointer). // -// One might be tempted to ignore the write barrier if slot points -// into to the stack. Don't do it! Mark termination only re-scans -// frames that have potentially been active since the concurrent scan, -// so it depends on write barriers to track changes to pointers in -// stack frames that have not been active. -// // // Global writes: //