From: Erik Aigner <aigner.erik@gmail.com>
Date: Mon, 2 Feb 2015 07:52:41 +0000 (+0100)
Subject: net/http: remove redundant strings.TrimPrefix
X-Git-Tag: go1.5beta1~2175
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=77067c169737eee8af4320ae2278f36d50291b14;p=gostls13.git

net/http: remove redundant strings.TrimPrefix

We already checked for the prefix with strings.HasPrefix

Change-Id: I33852fd19ffa92aa33b75b94b4bb505f4043a54a
Reviewed-on: https://go-review.googlesource.com/3691
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/net/http/request.go b/src/net/http/request.go
index 487eebcb84..63d7d44aa0 100644
--- a/src/net/http/request.go
+++ b/src/net/http/request.go
@@ -536,10 +536,11 @@ func (r *Request) BasicAuth() (username, password string, ok bool) {
 // parseBasicAuth parses an HTTP Basic Authentication string.
 // "Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==" returns ("Aladdin", "open sesame", true).
 func parseBasicAuth(auth string) (username, password string, ok bool) {
-	if !strings.HasPrefix(auth, "Basic ") {
+	const prefix = "Basic "
+	if !strings.HasPrefix(auth, prefix) {
 		return
 	}
-	c, err := base64.StdEncoding.DecodeString(strings.TrimPrefix(auth, "Basic "))
+	c, err := base64.StdEncoding.DecodeString(auth[len(prefix):])
 	if err != nil {
 		return
 	}