From: Brad Fitzpatrick Date: Tue, 28 May 2019 17:45:22 +0000 (+0000) Subject: net/http: quiet some log spam in tests X-Git-Tag: go1.13beta1~190 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=770746af1cf7900cb770767584abd3251013d932;p=gostls13.git net/http: quiet some log spam in tests One of these tests creates a bunch of connections concurrently, then discovers it doesn't need them all, which then makes the server log that the client went away midway through the TLS handshake. Perhaps the server should recognize that as a case not worthy of logging about, but this is a safer way to eliminate the stderr spam during go test for now. The other test's client gives up on its connection and closes it, similarly confusing the server. Change-Id: I49ce442c9a63fc437e58ca79f044aa76e8c317b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/179179 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Dmitri Shuralyov --- diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index 2f031e2f9b..de490bc607 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -1292,7 +1292,7 @@ func testClientTimeout_Headers(t *testing.T, h2 bool) { donec := make(chan bool, 1) cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { <-donec - })) + }), optQuietLog) defer cst.close() // Note that we use a channel send here and not a close. // The race detector doesn't know that we're waiting for a timeout diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index d774915719..1c67b40161 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -4282,7 +4282,7 @@ func testServerEmptyBodyRace(t *testing.T, h2 bool) { var n int32 cst := newClientServerTest(t, h2, HandlerFunc(func(rw ResponseWriter, req *Request) { atomic.AddInt32(&n, 1) - })) + }), optQuietLog) defer cst.close() var wg sync.WaitGroup const reqs = 20