From: Michael Anthony Knyszek Date: Mon, 9 Jun 2025 22:54:54 +0000 (+0000) Subject: internal/trace: pass GOTRACEBACK=crash to testprogs X-Git-Tag: go1.25rc1~1^2~3 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=773701a853;p=gostls13.git internal/trace: pass GOTRACEBACK=crash to testprogs The failures in #70310 are hard to decipher. The cases where the lock is being held either don't really make sense (the STW failures) or the goroutine that fails is 'running on another thread' and we don't get a stack trace. In fact, such a goroutine exists even in the STW cases. Since reproducing this is going to be hard (very few failures over a 2 year span) let's set GOTRACEBACK=crash for these testprogs so next time it happens we can see why. For #70310. Change-Id: I81a780aa82b173d42973f06911cb243f33352be1 Reviewed-on: https://go-review.googlesource.com/c/go/+/680476 Reviewed-by: Michael Pratt LUCI-TryBot-Result: Go LUCI Reviewed-by: Carlos Amedee --- diff --git a/src/internal/trace/trace_test.go b/src/internal/trace/trace_test.go index 0aa297d762..7eb50d0f4e 100644 --- a/src/internal/trace/trace_test.go +++ b/src/internal/trace/trace_test.go @@ -600,6 +600,10 @@ func testTraceProg(t *testing.T, progName string, extra func(t *testing.T, trace godebug += "," + extraGODEBUG } cmd.Env = append(cmd.Env, "GODEBUG="+godebug) + if _, ok := os.LookupEnv("GOTRACEBACK"); !ok { + // Unless overriden, set GOTRACEBACK=crash. + cmd.Env = append(cmd.Env, "GOTRACEBACK=crash") + } // Capture stdout and stderr. //