From: David Chase <drchase@google.com>
Date: Mon, 9 Jan 2023 18:36:36 +0000 (-0500)
Subject: net: add testing.Short Skip to test affected by local network configuration
X-Git-Tag: go1.21rc1~1840
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=780fa2426073035459b8a5d8e317f47864132ce4;p=gostls13.git

net: add testing.Short Skip to test affected by local network configuration

If the local network mangles invalid DNS queries, that is not a Go problem.

Change-Id: I54db392532eed988bca81b70a98cd6d11766af89
Reviewed-on: https://go-review.googlesource.com/c/go/+/461275
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
---

diff --git a/src/net/dnsclient_unix_test.go b/src/net/dnsclient_unix_test.go
index 3ba19eb813..990b3f99ce 100644
--- a/src/net/dnsclient_unix_test.go
+++ b/src/net/dnsclient_unix_test.go
@@ -2199,6 +2199,9 @@ var goLookupIPCNAMEOrderDNSFilesModeTests = []struct {
 }
 
 func TestGoLookupIPCNAMEOrderHostsAliasesDNSFilesMode(t *testing.T) {
+	if testing.Short() {
+		t.Skip("Makes assumptions about local networks and (re)naming that aren't always true")
+	}
 	defer func(orig string) { testHookHostsPath = orig }(testHookHostsPath)
 	testHookHostsPath = "testdata/aliases"
 	mode := hostLookupDNSFiles