From: Richard Musiol <mail@richard-musiol.de>
Date: Wed, 28 Oct 2020 23:07:04 +0000 (+0100)
Subject: misc/wasm: check type of argument to Go.run
X-Git-Tag: go1.16beta1~359
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=7be8358f70ff858f28b9aefe11986da25f1762bc;p=gostls13.git

misc/wasm: check type of argument to Go.run

This results in a nicer error message if the argument to Go.run is
omitted or of the wrong type.

Fixes #37000

Change-Id: I7f36d007f41a79b2cea1cebf5cce127786341202
Reviewed-on: https://go-review.googlesource.com/c/go/+/266117
Trust: Richard Musiol <neelance@gmail.com>
Run-TryBot: Richard Musiol <neelance@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
---

diff --git a/misc/wasm/wasm_exec.js b/misc/wasm/wasm_exec.js
index 3ea03c45b7..82041e6bb9 100644
--- a/misc/wasm/wasm_exec.js
+++ b/misc/wasm/wasm_exec.js
@@ -503,6 +503,9 @@
 		}
 
 		async run(instance) {
+			if (!(instance instanceof WebAssembly.Instance)) {
+				throw new Error("Go.run: WebAssembly.Instance expected");
+			}
 			this._inst = instance;
 			this.mem = new DataView(this._inst.exports.mem.buffer);
 			this._values = [ // JS values that Go currently has references to, indexed by reference id