From: Ian Lance Taylor <iant@golang.org>
Date: Tue, 7 Nov 2017 23:03:53 +0000 (-0800)
Subject: cmd/go: don't run TestUserOverrideFlags in parallel
X-Git-Tag: go1.10beta1~352
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=7d33667218ab010022a73b41ea9780474128a35f;p=gostls13.git

cmd/go: don't run TestUserOverrideFlags in parallel

It creates files in the cmd/go directory, which can confuse other tests.

Fixes #22584.

Change-Id: Iad5a25c62e7d413af1648dbc5359ed78bfd61d2a
Reviewed-on: https://go-review.googlesource.com/76398
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go
index ca1e392833..c2a4f517ec 100644
--- a/src/cmd/go/go_test.go
+++ b/src/cmd/go/go_test.go
@@ -4342,7 +4342,8 @@ func TestUserOverrideFlags(t *testing.T) {
 
 	tg := testgo(t)
 	defer tg.cleanup()
-	tg.parallel()
+	// Don't call tg.parallel, as creating override.h and override.a may
+	// confuse other tests.
 	tg.tempFile("override.go", `package main
 
 import "C"