From: Michael Pratt <mpratt@google.com>
Date: Fri, 7 Jan 2022 22:11:41 +0000 (-0500)
Subject: runtime: skip TestSegv traceback check on 386
X-Git-Tag: go1.18beta2~139
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=7f3eb6182ba72b1b45cf313a01b9c7d4b374255f;p=gostls13.git

runtime: skip TestSegv traceback check on 386

The VDSO (__kernel_vsyscall) is reachable via
asmcgocall(cgo_start_thread) on linux-386, which causes traceback to
throw.

Fixes #49182.
For #50504.

Change-Id: Idb78cb8de752203ce0ed63c2dbd2d12847338688
Reviewed-on: https://go-review.googlesource.com/c/go/+/376656
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
---

diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go
index 058eae1c09..abaed40977 100644
--- a/src/runtime/crash_cgo_test.go
+++ b/src/runtime/crash_cgo_test.go
@@ -625,12 +625,20 @@ func TestSegv(t *testing.T) {
 				// TODO(golang.org/issue/49182): Skip, runtime
 				// throws while attempting to generate
 				// traceback.
-			default:
-				nowant := "runtime: "
-				if strings.Contains(got, nowant) {
-					t.Errorf("unexpectedly saw %q in output", nowant)
+				return
+			case "linux":
+				if runtime.GOARCH == "386" {
+					// TODO(golang.org/issue/50504): Skip,
+					// runtime throws while attempting to
+					// generate traceback from VDSO call
+					// via asmcgocall.
+					return
 				}
 			}
+			nowant := "runtime: "
+			if strings.Contains(got, nowant) {
+				t.Errorf("unexpectedly saw %q in output", nowant)
+			}
 		})
 	}
 }