From: Alex Brainman <alex.brainman@gmail.com>
Date: Thu, 9 Nov 2017 23:26:05 +0000 (+1100)
Subject: cmd/go: close unintentionally left open file
X-Git-Tag: go1.10beta1~333
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=821e3f7d85e4f05d83f5f93e99bf299a6bfc9034;p=gostls13.git

cmd/go: close unintentionally left open file

cmd/go/internal/work.Builder.updateBuildID left a file opened.
But opened files cannot be deleted on Windows, so cmd/go just
leaves these files in %TMP% directory.

Close the file so deletion can succeed.

Fixes #22650

Change-Id: Ia3ea62f6ec7208d73972eae2e17fb4a766407914
Reviewed-on: https://go-review.googlesource.com/76810
Reviewed-by: Dave Cheney <dave@cheney.net>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/go/internal/work/buildid.go b/src/cmd/go/internal/work/buildid.go
index d7cc7a263b..caf6195abb 100644
--- a/src/cmd/go/internal/work/buildid.go
+++ b/src/cmd/go/internal/work/buildid.go
@@ -448,6 +448,7 @@ func (b *Builder) updateBuildID(a *Action, target string, rewrite bool) error {
 		r, err := os.Open(target)
 		if err == nil {
 			c.Put(a.actionID, r)
+			r.Close()
 		}
 	}