From: Cherry Zhang <cherryyz@google.com>
Date: Fri, 8 May 2020 21:12:45 +0000 (-0400)
Subject: cmd/compile: remove unnecessary error condition on reading fingerprint
X-Git-Tag: go1.16beta1~1278
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=84a62453e5c01df3f7d0c48d9aca32832c2052c1;p=gostls13.git

cmd/compile: remove unnecessary error condition on reading fingerprint

io.ReadFull guarantees n == len(buf) if and only if err == nil,
so the length check is redundant.

Change-Id: I15bff97868e27a65648acd791883cac8dab77630
Reviewed-on: https://go-review.googlesource.com/c/go/+/232988
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
---

diff --git a/src/cmd/compile/internal/gc/iimport.go b/src/cmd/compile/internal/gc/iimport.go
index 0eeb047c06..4169222c14 100644
--- a/src/cmd/compile/internal/gc/iimport.go
+++ b/src/cmd/compile/internal/gc/iimport.go
@@ -191,9 +191,9 @@ func iimport(pkg *types.Pkg, in *bio.Reader) (fingerprint goobj.FingerprintType)
 		}
 	}
 
-	// Fingerprint
-	n, err := io.ReadFull(in, fingerprint[:])
-	if err != nil || n != len(fingerprint) {
+	// Fingerprint.
+	_, err = io.ReadFull(in, fingerprint[:])
+	if err != nil {
 		yyerror("import %s: error reading fingerprint", pkg.Path)
 		errorexit()
 	}