From: Russ Cox Date: Fri, 19 Sep 2014 00:13:07 +0000 (-0400) Subject: os: skip TestRemoveAllRace on Windows X-Git-Tag: go1.4beta1~354 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=84f9c42bbbfb67c2ef78d4a4e19417329d7f8f5a;p=gostls13.git os: skip TestRemoveAllRace on Windows It's just fundamentally incompatible with Windows' pickiness about removing things that are in use. TBR=brainman CC=golang-codereviews https://golang.org/cl/142270043 --- diff --git a/src/os/os_test.go b/src/os/os_test.go index 7a28497414..973cc3a7bf 100644 --- a/src/os/os_test.go +++ b/src/os/os_test.go @@ -1422,6 +1422,14 @@ func mkdirTree(t *testing.T, root string, level, max int) { // Test that simultaneous RemoveAll do not report an error. // As long as it gets removed, we should be happy. func TestRemoveAllRace(t *testing.T) { + if runtime.GOOS == "windows" { + // Windows has very strict rules about things like + // removing directories while someone else has + // them open. The racing doesn't work out nicely + // like it does on Unix. + t.Skip("skipping on windows") + } + n := runtime.GOMAXPROCS(16) defer runtime.GOMAXPROCS(n) root, err := ioutil.TempDir("", "issue")