From: Mikio Hara Date: Wed, 27 Feb 2019 11:56:43 +0000 (+0900) Subject: Revert "net: add missing error check in test" X-Git-Tag: go1.13beta1~1341 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=850e3636d5d269c71df22a88f49423fe87179519;p=gostls13.git Revert "net: add missing error check in test" This reverts commit ec521467e33eee0a62ed426ca0c66b865baedfc7. Reson for revert: The test cases using slowDst4 and slowDst6 are fragile. We need to find out a better approach to the trick on the IP routeability. Change-Id: I544453886e809d1c7b339673d8f1d5bdef357147 Reviewed-on: https://go-review.googlesource.com/c/163919 Reviewed-by: Bryan C. Mills Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot --- diff --git a/src/net/dial_test.go b/src/net/dial_test.go index 07d2bb22aa..3a2c59a2d1 100644 --- a/src/net/dial_test.go +++ b/src/net/dial_test.go @@ -338,11 +338,6 @@ func TestDialParallel(t *testing.T) { if c != nil { c.Close() } - if tt.expectOk && err != nil { - t.Errorf("#%d (cancel): got %v; want nil", i, err) - } else if !tt.expectOk && err == nil { - t.Errorf("#%d (cancel): got nil; want non-nil", i) - } elapsed = time.Now().Sub(startTime) if elapsed > 100*time.Millisecond { t.Errorf("#%d (cancel): got %v; want <= 100ms", i, elapsed)