From: Matthew Dempsky <mdempsky@google.com>
Date: Thu, 11 Aug 2022 19:29:47 +0000 (-0700)
Subject: test: make issue54343.go robust against the tiny allocator
X-Git-Tag: go1.20rc1~1689
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=87431981522981bc69b1eccc392e101df3318c2e;p=gostls13.git

test: make issue54343.go robust against the tiny allocator

I structured the test for issue54343.go after issue46725.go, where I
was careful to use `[4]int`, which is a type large enough to avoid the
tiny object allocator (which interferes with finalizer semantics). But
in that test, I didn't note the importance of that type, so I
mistakenly used just `int` in issue54343.go.

This CL switches issue54343.go to use `[4]int` too, and then adds
comments to both pointing out the significance of this type.

Updates #54343.

Change-Id: I699b3e64b844ff6d8438bbcb4d1935615a6d8cc4
Reviewed-on: https://go-review.googlesource.com/c/go/+/423115
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
---

diff --git a/test/fixedbugs/issue46725.go b/test/fixedbugs/issue46725.go
index 29799c7d7e..f6e443e60f 100644
--- a/test/fixedbugs/issue46725.go
+++ b/test/fixedbugs/issue46725.go
@@ -8,7 +8,7 @@ package main
 
 import "runtime"
 
-type T [4]int
+type T [4]int // N.B., [4]int avoids runtime's tiny object allocator
 
 //go:noinline
 func g(x []*T) ([]*T, []*T) { return x, x }
diff --git a/test/fixedbugs/issue54343.go b/test/fixedbugs/issue54343.go
index f8f73f4048..10b91a5398 100644
--- a/test/fixedbugs/issue54343.go
+++ b/test/fixedbugs/issue54343.go
@@ -26,7 +26,7 @@ func New[X any]() *T[X] {
 	return p
 }
 
-type T[X any] int
+type T[X any] [4]int // N.B., [4]int avoids runtime's tiny object allocator
 
 func (*T[X]) M() {}