From: Brad Fitzpatrick Date: Thu, 29 Jan 2015 12:45:56 +0000 (+0100) Subject: cmd/pack: make a test less disk-intensive in short mode X-Git-Tag: go1.5beta1~1915^2~80 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=878d00b65c829c45ef5aebc84e506265f53a0265;p=gostls13.git cmd/pack: make a test less disk-intensive in short mode Fixes #9656 Change-Id: I1158636683492ef12eeafb12e257d205026adc3f Reviewed-on: https://go-review.googlesource.com/3175 Reviewed-by: Minux Ma Reviewed-on: https://go-review.googlesource.com/3910 Reviewed-by: Dave Cheney --- diff --git a/src/cmd/pack/pack_test.go b/src/cmd/pack/pack_test.go index cf6121fcc1..fbc6a3c698 100644 --- a/src/cmd/pack/pack_test.go +++ b/src/cmd/pack/pack_test.go @@ -257,8 +257,15 @@ func TestLargeDefs(t *testing.T) { } } + n := 10000 + if testing.Short() { + // Issue 9656: 10,000 is too aggressive for several + // builders, with ~120 MB of disk consumed. 1,000 is + // still enough to exercise the old bug. + n = 1000 + } printf("package large\n\ntype T struct {\n") - for i := 0; i < 10000; i++ { + for i := 0; i < n; i++ { printf("f%d int `tag:\"", i) for j := 0; j < 100; j++ { printf("t%d=%d,", j, j)