From: Matthew Dempsky <mdempsky@google.com>
Date: Wed, 1 Sep 2021 19:42:35 +0000 (-0700)
Subject: cmd/compile: optimize unified IR handling of imported functions
X-Git-Tag: go1.18beta1~1525
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=88859f3cd8;p=gostls13.git

cmd/compile: optimize unified IR handling of imported functions

This CL skips reading of imported function bodies except from the
local package or for inlining. Previously, we wasted a bunch of CPU
and memory by reading in normal function bodies for all imported
functions and methods.

Change-Id: I0b3df3f4a3e2819117dac11a1f9e4526288c14d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/347030
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
---

diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go
index 17ccb25e1d..204d25bce8 100644
--- a/src/cmd/compile/internal/noder/reader.go
+++ b/src/cmd/compile/internal/noder/reader.go
@@ -920,6 +920,12 @@ func (r *reader) addBody(fn *ir.Func) {
 	pri := pkgReaderIndex{r.p, r.reloc(relocBody), r.dict}
 	bodyReader[fn] = pri
 
+	if fn.Nname.Defn == nil {
+		// Don't read in function body for imported functions.
+		// See comment in funcExt.
+		return
+	}
+
 	if r.curfn == nil {
 		todoBodies = append(todoBodies, fn)
 		return