From: Russ Cox Date: Thu, 7 Apr 2011 17:06:02 +0000 (-0400) Subject: codereview: fix clpatch X-Git-Tag: weekly.2011-04-13~77 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=88bbf4f1dff08507bb860bbf81219f34dce9eb83;p=gostls13.git codereview: fix clpatch I love Python. Write once, crash anywhere. TBR=r CC=golang-dev https://golang.org/cl/4382043 --- diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index bd9a179f82..827054bf0b 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1333,16 +1333,16 @@ def reposetup(ui, repo): def CheckContributor(ui, repo, user=None): set_status("checking CONTRIBUTORS file") - if not user: - user = ui.config("ui", "username") - if not user: - raise util.Abort("[ui] username is not configured in .hgrc") _, userline = FindContributor(ui, repo, user, warn=False) if not userline: raise util.Abort("cannot find %s in CONTRIBUTORS" % (user,)) return userline -def FindContributor(ui, repo, user, warn=True): +def FindContributor(ui, repo, user=None, warn=True): + if not user: + user = ui.config("ui", "username") + if not user: + raise util.Abort("[ui] username is not configured in .hgrc") user = user.lower() m = re.match(r".*<(.*)>", user) if m: