From: Russ Cox Date: Thu, 3 Nov 2016 13:13:16 +0000 (-0400) Subject: cmd/pprof: use correct default handler for Go programs X-Git-Tag: go1.8beta1~358 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=89ccd5795c5e41ef478eab3d4a292a836a7fe3ad;p=gostls13.git cmd/pprof: use correct default handler for Go programs The original go tool pprof (written in Perl) got this right. The Go rewrite never has, but should. Change-Id: Ie1fc571214c61b1b5654a0bc90e15eb889adf059 Reviewed-on: https://go-review.googlesource.com/32617 Run-TryBot: Russ Cox Reviewed-by: Ian Lance Taylor --- diff --git a/src/cmd/pprof/internal/driver/driver.go b/src/cmd/pprof/internal/driver/driver.go index 344d458e13..931985a7f2 100644 --- a/src/cmd/pprof/internal/driver/driver.go +++ b/src/cmd/pprof/internal/driver/driver.go @@ -28,6 +28,9 @@ import ( "internal/pprof/profile" ) +// cpuProfileHandler is the Go pprof CPU profile handler URL. +const cpuProfileHandler = "/debug/pprof/profile" + // PProf acquires a profile, and symbolizes it using a profile // manager. Then it generates a report formatted according to the // options selected through the flags package. @@ -160,10 +163,10 @@ func adjustURL(source string, sec int, ui plugin.UI) (adjusted, host string, dur switch strings.ToLower(url.Path) { case "", "/": // Apply default /profilez. - url.Path = "/profilez" + url.Path = cpuProfileHandler case "/protoz": // Rewrite to /profilez?type=proto - url.Path = "/profilez" + url.Path = cpuProfileHandler values.Set("type", "proto") }