From: Russ Cox <rsc@golang.org>
Date: Thu, 30 Apr 2009 01:54:44 +0000 (-0700)
Subject: don't set CLONE_PTRACE -- it confuses strace
X-Git-Tag: weekly.2009-11-06~1738
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=89f8238a996e08a0a7df85db81cf0338c89de244;p=gostls13.git

don't set CLONE_PTRACE -- it confuses strace

R=r
DELTA=4  (3 added, 1 deleted, 0 changed)
OCL=28063
CL=28065
---

diff --git a/src/runtime/linux/thread.c b/src/runtime/linux/thread.c
index 4375eca9fc..cc9ba161bf 100644
--- a/src/runtime/linux/thread.c
+++ b/src/runtime/linux/thread.c
@@ -237,12 +237,14 @@ newosproc(M *m, G *g, void *stk, void (*fn)(void))
 	int64 ret;
 	int32 flags;
 
+	/*
+	 * note: strace gets confused if we use CLONE_PTRACE here.
+	 */
 	flags = CLONE_PARENT	/* getppid doesn't change in child */
 		| CLONE_VM	/* share memory */
 		| CLONE_FS	/* share cwd, etc */
 		| CLONE_FILES	/* share fd table */
 		| CLONE_SIGHAND	/* share sig handler table */
-		| CLONE_PTRACE	/* revisit - okay for now */
 		| CLONE_THREAD	/* revisit - okay for now */
 		;