From: Josh Bleecher Snyder <josharian@gmail.com>
Date: Fri, 9 Jan 2015 19:57:51 +0000 (-0800)
Subject: cmd/5g, cmd/6g, cmd/8g, cmd/9g: zero more in componentgen
X-Git-Tag: go1.5beta1~2026
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=8f734d4e2fc4592054a5cb3989465323465a93ac;p=gostls13.git

cmd/5g, cmd/6g, cmd/8g, cmd/9g: zero more in componentgen

Fix a flipped nil check.
The flipped check prevented componentgen
from zeroing a non-cadable nl.
This fix reduces the number of non-SB LEAQs
in godoc from 35323 to 34920 (-1.1%).

Update #1914

Change-Id: I15ea303068835f606f883ddf4a2bb4cb2287e9ae
Reviewed-on: https://go-review.googlesource.com/2605
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
---

diff --git a/src/cmd/5g/cgen.c b/src/cmd/5g/cgen.c
index 6acf6dfdf0..aa64d05ed0 100644
--- a/src/cmd/5g/cgen.c
+++ b/src/cmd/5g/cgen.c
@@ -1680,7 +1680,7 @@ componentgen(Node *nr, Node *nl)
 
 	nodl = *nl;
 	if(!cadable(nl)) {
-		if(nr == N || !cadable(nr))
+		if(nr != N && !cadable(nr))
 			goto no;
 		igen(nl, &nodl, N);
 		freel = 1;
diff --git a/src/cmd/6g/cgen.c b/src/cmd/6g/cgen.c
index 5e98934da6..fa7d1eefbe 100644
--- a/src/cmd/6g/cgen.c
+++ b/src/cmd/6g/cgen.c
@@ -1587,7 +1587,7 @@ componentgen(Node *nr, Node *nl)
 
 	nodl = *nl;
 	if(!cadable(nl)) {
-		if(nr == N || !cadable(nr))
+		if(nr != N && !cadable(nr))
 			goto no;
 		igen(nl, &nodl, N);
 		freel = 1;
diff --git a/src/cmd/8g/cgen.c b/src/cmd/8g/cgen.c
index c65a437857..a0e39c0ffe 100644
--- a/src/cmd/8g/cgen.c
+++ b/src/cmd/8g/cgen.c
@@ -1427,7 +1427,7 @@ componentgen(Node *nr, Node *nl)
 
 	nodl = *nl;
 	if(!cadable(nl)) {
-		if(nr == N || !cadable(nr))
+		if(nr != N && !cadable(nr))
 			goto no;
 		igen(nl, &nodl, N);
 		freel = 1;
diff --git a/src/cmd/9g/cgen.c b/src/cmd/9g/cgen.c
index 706658de0e..e4520fb44d 100644
--- a/src/cmd/9g/cgen.c
+++ b/src/cmd/9g/cgen.c
@@ -1602,7 +1602,7 @@ componentgen(Node *nr, Node *nl)
 
 	nodl = *nl;
 	if(!cadable(nl)) {
-		if(nr == N || !cadable(nr))
+		if(nr != N && !cadable(nr))
 			goto no;
 		igen(nl, &nodl, N);
 		freel = 1;