From: Muhammad Falak R Wani <falakreyaz@gmail.com>
Date: Thu, 14 Jun 2018 18:37:32 +0000 (+0530)
Subject: cmd/objdump: defer closing the file after opening
X-Git-Tag: go1.12beta1~1393
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9087d13ec3e39e50aae6c6a8cf99dc66225ab132;p=gostls13.git

cmd/objdump: defer closing the file after opening

Remove the os.Exit(0) to honor the deferred closing of the file.

Change-Id: Iaa9304d8203c8fec0ec728af669a94eadd36905c
Reviewed-on: https://go-review.googlesource.com/118915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/objdump/main.go b/src/cmd/objdump/main.go
index 71636990a1..6a60697ebd 100644
--- a/src/cmd/objdump/main.go
+++ b/src/cmd/objdump/main.go
@@ -75,6 +75,7 @@ func main() {
 	if err != nil {
 		log.Fatal(err)
 	}
+	defer f.Close()
 
 	dis, err := f.Disasm()
 	if err != nil {
@@ -87,7 +88,6 @@ func main() {
 	case 1:
 		// disassembly of entire object
 		dis.Print(os.Stdout, symRE, 0, ^uint64(0), *printCode)
-		os.Exit(0)
 
 	case 3:
 		// disassembly of PC range
@@ -100,6 +100,5 @@ func main() {
 			log.Fatalf("invalid end PC: %v", err)
 		}
 		dis.Print(os.Stdout, symRE, start, end, *printCode)
-		os.Exit(0)
 	}
 }