From: Hiroshi Ioka Date: Sat, 12 Aug 2017 15:19:51 +0000 (+0900) Subject: cmd/link: correct Mach-O file flag X-Git-Tag: go1.10beta1~1582 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=90ffc40e4f3d81ad6b9f57092074f8fef68cf128;p=gostls13.git cmd/link: correct Mach-O file flag Only set MH_NOUNDEFS if there are no undefined symbols. Doesn't seem to matter, but may as well do it right. Change-Id: I6c472e000578346c28cf0e10f24f870e3a0de628 Reviewed-on: https://go-review.googlesource.com/55310 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- diff --git a/src/cmd/link/internal/ld/macho.go b/src/cmd/link/internal/ld/macho.go index 161833f357..ccdbc54f66 100644 --- a/src/cmd/link/internal/ld/macho.go +++ b/src/cmd/link/internal/ld/macho.go @@ -263,7 +263,11 @@ func machowrite() int { } Thearch.Lput(uint32(len(load)) + uint32(nseg) + uint32(ndebug)) Thearch.Lput(uint32(loadsize)) - Thearch.Lput(MH_NOUNDEFS) /* flags - no undefines */ + if nkind[SymKindUndef] == 0 { + Thearch.Lput(MH_NOUNDEFS) /* flags - no undefines */ + } else { + Thearch.Lput(0) /* flags */ + } if macho64 { Thearch.Lput(0) /* reserved */ }