From: Than McIntosh <thanm@google.com>
Date: Tue, 22 Nov 2022 15:42:25 +0000 (-0500)
Subject: cmd/dist: skip -race w/ external linkage on windows 2008
X-Git-Tag: go1.20rc1~108
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9160e15494ed03967b86ddc1a601b659b3243fd0;p=gostls13.git

cmd/dist: skip -race w/ external linkage on windows 2008

Add a skip for the external-linkage part of the race detector test for
elderly versions of windows, until the underlying cause for the problem
can be determined.

Updates #56904.

Change-Id: I3e8650ff66f34efefabcd6bc343d57124539901b
Reviewed-on: https://go-review.googlesource.com/c/go/+/452763
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index eadca9c08f..316a9b9ddd 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -1602,14 +1602,18 @@ func (t *tester) registerRaceTests() {
 		// t.registerTest("race:misc/cgo/test", hdr, &goTest{dir: "../misc/cgo/test", race: true, env: []string{"GOTRACEBACK=2"}})
 	}
 	if t.extLink() {
-		// Test with external linking; see issue 9133.
-		t.registerTest("race:external", hdr,
-			&goTest{
-				race:     true,
-				ldflags:  "-linkmode=external",
-				runTests: "TestParse|TestEcho|TestStdinCloseRace",
-				pkgs:     []string{"flag", "os/exec"},
-			})
+		if strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "windows-amd64-2008") {
+			log.Printf("skipping -race with external linkage on older windows builder, see https://github.com/golang/go/issues/56904 for details")
+		} else {
+			// Test with external linking; see issue 9133.
+			t.registerTest("race:external", hdr,
+				&goTest{
+					race:     true,
+					ldflags:  "-linkmode=external",
+					runTests: "TestParse|TestEcho|TestStdinCloseRace",
+					pkgs:     []string{"flag", "os/exec"},
+				})
+		}
 	}
 }